Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add namespace exported declare function support #91 and fix #94 #92

Merged
merged 2 commits into from
Aug 16, 2021

Conversation

deepkolos
Copy link
Contributor

@deepkolos deepkolos commented Aug 13, 2021

add type annotation and namespace exported declare function support #91 and fix #94

/** @type {asc.Program} */
const program = this.program;
=== Browser results
✓ as-bind should handle array
✓ as-bind should handle nested array
✓ as-bind should handle ArrayBuffers
✓ as-bind should handle Uint8Arrays
✓ as-bind should be extensible with custom type handlers
✓ as-bind should handle the prototype chain on the imports object
✓ as-bind works synchronously
✓ as-bind should handle multiple files correctly
✓ as-bind should support exported declare function in namespace
✓ as-bind should not GC strings
✓ as-bind should handle strings
✓ as-bind should handle unexpected imports gracefully
✓ as-bind should handle unknown types gracefully
✓ as-bind should handle unused imported functions gracefully

@deepkolos deepkolos changed the title feat: add namespace support #91 feat: add namespace exported declare function support #91 Aug 13, 2021
@deepkolos deepkolos changed the title feat: add namespace exported declare function support #91 feat: add namespace exported declare function support #91 and fix #94 Aug 13, 2021
@FGasper
Copy link
Contributor

FGasper commented Aug 14, 2021

I have an additional changeset that allows @external annotations to work. I’ll send it in once this PR merges.

Copy link
Owner

@torch2424 torch2424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Thank you soooo much for this PR! 😄 Everything looks great to me, and thank you for adding a test for this! Approving and merging, and deploying a new version!

cc @FGasper since you said you were waiting on this PR 😄

@torch2424
Copy link
Owner

Published in: https://github.com/torch2424/as-bind/releases/tag/0.8.1 😄 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Float32Array was bind to ArrayBuffer
3 participants