Allowed Translating the Homepage, and fixed redirect 404 when switching reading languages #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #96 relates to #105
This allows the homepage to be translated 😄 However, opens #106 as there is still some hardcoded english in the "shell", that could be translatable. But I will address this another day, as I should work on some upcoming talks I have haha! 😂
cc @fbitti , you'll just need to add the corresponding translation for "pt-br" where you see "en-us" in
build-system/homepage.js, and you should be good to go! 😄 👍Screenshot
Needs the categories to be translated, everything will default to english