Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyze Closure Compiler Output to help Improve Wasm Output #207

Closed
torch2424 opened this issue Dec 4, 2018 · 0 comments · Fixed by #264
Closed

Analyze Closure Compiler Output to help Improve Wasm Output #207

torch2424 opened this issue Dec 4, 2018 · 0 comments · Fixed by #264
Assignees
@torch2424
Labels
Core/Wasm Issues concerning the core library of Wasmboy enhancement New feature or request

Comments

@torch2424
Copy link
Owner

Since we now have Closure Compiler builds, noticed that closure can do huge performance improvements for our JS Builds. Got some advice that we can configure closure to not mangle names. And we can check and see what functions are being inlined, that may improve performance binaryen may not already be doing for us 😄
@torch2424 torch2424 added enhancement New feature or request Core/Wasm Issues concerning the core library of Wasmboy labels Dec 4, 2018
@torch2424 torch2424 self-assigned this Dec 4, 2018
@torch2424 torch2424 changed the title Analyze Colusre Compiler Output to help Improve Wasm Output Analyze Colsure Compiler Output to help Improve Wasm Output Dec 4, 2018
@torch2424 torch2424 changed the title Analyze Colsure Compiler Output to help Improve Wasm Output Analyze Closure Compiler Output to help Improve Wasm Output Dec 4, 2018
torch2424 added a commit that referenced this issue Feb 21, 2019
@torch2424
issue #207, Allowed making closure builds for debugging, and then tried
1cdfaf5 
to match its inlining
@torch2424 torch2424 mentioned this issue Feb 21, 2019
Merged
torch2424 added a commit that referenced this issue Feb 22, 2019
@torch2424
Optimization / Performance cleanup (#264)
1de7031 
* Implemented all changes from #230 and #221

* Fixed off by one mentioned in #216

* Wrapped modulo in i32Portable as mentioned in #216

* issue #207, Allowed making closure builds for debugging, and then tried
to match its inlining

* Removed the legacy api

* Updated the package-lock for the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@torch2424 torch2424

Labels
Core/Wasm Issues concerning the core library of Wasmboy enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimization / Performance cleanup torch2424/wasmboy
1 participant
@torch2424