-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wagtail 6.0 #2
Wagtail 6.0 #2
Conversation
…agtail.contrib.search_promotions
…ired argument for StreamFields and has no effect
…ithScript should be replaced with a Stimulus integration
…hScript should be replaced with a Stimulus integration
…Script should be replaced with a Stimulus integration
3fc8806
to
807c4b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @katdom13 All looks OK to me.
But I wasn't able to use the address search anywhere. Did you get that part working? I can see the maps using my own maps key but may be the address search works with a different key.
Hi @nickmoreton , |
I think I see what you mean. This package supports searching from the following:
I've been testing this on Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @katdom13 I think this is good. Nice work on the javascript 😄
While I could see preview errors I just think it's because the testing site doesn't have templates mostly. But it's possible that this package was conceived before previews had there own panel.
I was able to add the correct services to my test api key and it took little while but address search did work in the end.
|
||
google_maps_apikey = callback() | ||
if self.value_data and isinstance(self.value_data, Point): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just adding a note of an error I saw ion a client site:
File "/venv/lib/python3.8/site-packages/wagtailgeowidget/widgets.py", line 85, in build_attrs
if self.value_data and isinstance(self.value_data, Point):
TypeError: isinstance() arg 2 must be a type or tuple of types
Support Ticket
Wagtail 6.0 release notes
Summary of changes
Added
Changed
Removed