Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wagtail 6.0 #2

Merged
merged 12 commits into from
Mar 13, 2024
Merged

Wagtail 6.0 #2

merged 12 commits into from
Mar 13, 2024

Conversation

katdom13
Copy link

@katdom13 katdom13 commented Feb 20, 2024

Support Ticket

Wagtail 6.0 release notes

Summary of changes

Added

  • Add support for Wagtail 6.0

Changed

  • Implement stimulus approach to GoogleMapsField, GeocoderField, and LeafletField

Removed

  • Drop support for Django 4.1

@katdom13 katdom13 self-assigned this Feb 20, 2024
Copy link
Collaborator

@nickmoreton nickmoreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @katdom13 All looks OK to me.

But I wasn't able to use the address search anywhere. Did you get that part working? I can see the maps using my own maps key but may be the address search works with a different key.

@katdom13
Copy link
Author

katdom13 commented Mar 7, 2024

Hi @katdom13 All looks OK to me.

But I wasn't able to use the address search anywhere. Did you get that part working? I can see the maps using my own maps key but may be the address search works with a different key.

Hi @nickmoreton ,
Could you let me know which page is that?
Thanks!

@katdom13
Copy link
Author

Hi @katdom13 All looks OK to me.

But I wasn't able to use the address search anywhere. Did you get that part working? I can see the maps using my own maps key but may be the address search works with a different key.

I think I see what you mean. This package supports searching from the following:

  1. Google Geocoding - I noticed that this has type suggestions when I try to search.
  2. Nominatim - This one doesn't, but the map should respond if I provide a complete address
  3. Mapbox - This one doesn't work for me.

I've been testing this on main (without the changes) as well as the current work branch but there's no significant difference.

Thanks!

Copy link
Collaborator

@nickmoreton nickmoreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @katdom13 I think this is good. Nice work on the javascript 😄
While I could see preview errors I just think it's because the testing site doesn't have templates mostly. But it's possible that this package was conceived before previews had there own panel.
I was able to add the correct services to my test api key and it took little while but address search did work in the end.

@katdom13 katdom13 merged commit a899a93 into main Mar 13, 2024
26 checks passed

google_maps_apikey = callback()
if self.value_data and isinstance(self.value_data, Point):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding a note of an error I saw ion a client site:

File "/venv/lib/python3.8/site-packages/wagtailgeowidget/widgets.py", line 85, in build_attrs
    if self.value_data and isinstance(self.value_data, Point):
TypeError: isinstance() arg 2 must be a type or tuple of types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants