Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints for public API #172

Closed
Tracked by #170
thibaudcolas opened this issue Jan 24, 2022 · 0 comments · Fixed by #189
Closed
Tracked by #170

Add type hints for public API #172

thibaudcolas opened this issue Jan 24, 2022 · 0 comments · Fixed by #189
Labels
django Related to Django templates capabilities enhancement New feature or request
Milestone
v1.0.0

Comments

@thibaudcolas
Copy link
Member

thibaudcolas commented Jan 24, 2022 •
edited
Loading

It’d be nice to do type checking of this project, for our own maintainability needs, and for consumers of this package.
@thibaudcolas thibaudcolas mentioned this issue Jan 24, 2022
Closed
23 tasks
@thibaudcolas thibaudcolas changed the title Add type annotations for public API? Add type checking & annotations Jan 24, 2022
@thibaudcolas thibaudcolas added django Related to Django templates capabilities enhancement New feature or request labels Jan 24, 2022
@thibaudcolas thibaudcolas added this to the v1.0.0 milestone Jan 24, 2022
@thibaudcolas thibaudcolas changed the title Add type checking & annotations Add type checking & annotations for public API Jan 24, 2022
@thibaudcolas thibaudcolas changed the title Add type checking & annotations for public API Add type hints for public API Jan 25, 2022
thibaudcolas added a commit that referenced this issue Jan 25, 2022
@thibaudcolas
Add type annotations to public API. Fix #172
e4970dd
@thibaudcolas thibaudcolas mentioned this issue Jan 25, 2022
Merged
6 tasks
thibaudcolas added a commit that referenced this issue Jan 25, 2022
@thibaudcolas
Add type annotations to public API. Fix #172
5a65bec
thibaudcolas added a commit that referenced this issue May 30, 2022
@thibaudcolas
Add type annotations to public API. Fix #172 (#189)
03030c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
django Related to Django templates capabilities enhancement New feature or request
Projects
No open projects
django-pattern-library v1.0.0 release
Status: In progress
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Add type annotations to public API. Fix #172 torchbox/django-pattern-library
1 participant
@thibaudcolas