-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeError with Django 4.1 #211
Comments
This relates to commit #854e9b0 on As noted on that commit, the output of |
See issue #166 & related PR #188 where the same change was fixed for parts of this project. It looks to me like this previous fix was incomplete - the value of @thibaudcolas What should the correct behaviour here be?
|
Firstly, it looks like there's a mistake in the code in That check was originally intended to prevent falsey values being disregarded so that, for example, you could pass My proposed fix would be to:
|
@bcdickinson Please see the PR linked above, which aims to implement your proposed fix. I've made the handling for non-string |
Issue Summary
Using with latest Django causes a
TypeError
(traceback below) that prevents the pattern library from rendering patterns.Technical details
Traceback
The text was updated successfully, but these errors were encountered: