Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #166, making sure we always cast raw tag override values to string #188

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

thibaudcolas
Copy link
Member

Description

Fixes #166, following the suggestion from @zerolab. I chose to do this for all Django versions rather than adding a conditional with version check, but happy to revisit this if people think it’s worthwhile.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation Not relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added an appropriate CHANGELOG entry

Suggested CHANGELOG entry:

### Changed

- Fix potential Django 4.0 compatibility issue for components using non-string values in tag overrides ([#166](https://github.com/torchbox/django-pattern-library/issues/166)).

@thibaudcolas thibaudcolas added django Related to Django templates capabilities enhancement New feature or request status: Needs review labels Jan 25, 2022
@thibaudcolas thibaudcolas added this to the v1.0.0 milestone Jan 25, 2022
@thibaudcolas thibaudcolas merged commit 8b10c53 into main Jan 25, 2022
@thibaudcolas thibaudcolas deleted the bug/166-nodelist-render-string branch January 25, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
django Related to Django templates capabilities enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Django 4.0 compatibility issue: Node.render should return a string
2 participants