Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit variable template names in extends and include tags #112

Closed
wants to merge 1 commit into from

Conversation

nimasmi
Copy link

@nimasmi nimasmi commented Jun 16, 2020

Description

This permits the use of an extends tag

{% extends foo %}

or an include tag

{% include foo %}

where the context defines foo.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@nimasmi nimasmi requested a review from bcdickinson June 16, 2020 15:16
@bcdickinson
Copy link
Collaborator

Thanks for this, Nick. I've rolled it into #124 so I'll close this PR now.

@thibaudcolas thibaudcolas deleted the feature/dynamic-template-names branch November 3, 2020 13:54
@thibaudcolas thibaudcolas added the enhancement New feature or request label Nov 3, 2020
@thibaudcolas thibaudcolas added this to the v0.3.0 milestone Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants