Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Black #187

Merged
merged 5 commits into from
Jan 24, 2022
Merged

Black #187

merged 5 commits into from
Jan 24, 2022

Conversation

bcdickinson
Copy link
Collaborator

@bcdickinson bcdickinson commented Jan 24, 2022 •
edited
Loading

Description

This:

  • Adds black
  • Upgrades isort to be compatible with black
  • Applies black to the repository

Fixes #174

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added an appropriate CHANGELOG entry

@bcdickinson bcdickinson self-assigned this Jan 24, 2022
@bcdickinson bcdickinson marked this pull request as ready for review January 24, 2022 18:27
thibaudcolas
thibaudcolas approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@thibaudcolas thibaudcolas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘 such black, much dark, very formatter
doge approves

@thibaudcolas thibaudcolas added the enhancement New feature or request label Jan 24, 2022
@thibaudcolas thibaudcolas added this to the v1.0.0 milestone Jan 24, 2022
@thibaudcolas thibaudcolas merged commit ce2ca10 into main Jan 24, 2022
@thibaudcolas thibaudcolas deleted the black branch January 24, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibaudcolas thibaudcolas thibaudcolas approved these changes

Assignees

@bcdickinson bcdickinson

Labels
enhancement New feature or request
Projects
No open projects
django-pattern-library v1.0.0 release
Status: Done
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

black setup
2 participants
@bcdickinson @thibaudcolas