Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable pointer events on menu chevron to allow toggling. Fix #202 #205

Merged
merged 3 commits into from
Dec 9, 2022
Merged

Disable pointer events on menu chevron to allow toggling. Fix #202 #205

merged 3 commits into from
Dec 9, 2022

Conversation

nickmoreton
Copy link
Contributor

@nickmoreton nickmoreton commented Oct 17, 2022 •
edited

Description

A small styling change to stop the chevron SVG catching the menu clicks.

Fixes #202

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added an appropriate CHANGELOG entry

thibaudcolas
thibaudcolas approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff @nickmoreton!

@thibaudcolas thibaudcolas added bug Something isn't working ui Related to the user interface of the pattern library labels Dec 9, 2022
@thibaudcolas thibaudcolas added this to the v1.1.0 milestone Dec 9, 2022
@thibaudcolas thibaudcolas changed the title Disable pointer events on chevron. Disable pointer events on menu chevron to allow toggling. Fix #202 Dec 9, 2022
@thibaudcolas thibaudcolas merged commit 3fad362 into torchbox:main Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibaudcolas thibaudcolas thibaudcolas approved these changes

Assignees
No one assigned
Labels
bug Something isn't working ui Related to the user interface of the pattern library
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Clicking the menu chevron should expand/collapse the menu
2 participants
@nickmoreton @thibaudcolas