Upgrade/36-crispy-forms-gds

[lparsons396]

The following merged PRs to crispy-forms-gds can be pulled into our package:

1. Raise ValuationError if invalid date entered in DateInputField wildfish/crispy-forms-gds#59

2. Display dividers between checkbox choices wildfish/crispy-forms-gds#76:
   - we will need to check the CSS class name for the divider markup
   - see https://design-system.service.gov.uk/components/radios/ - the divider should be used to separate answers that are conceptually different

[lparsons396]

(I'm just fixing the failing tests now)

[jams2]

For the failure here, it looks like the issue is linebreaks in the wrong place in the fixture (this line and this line). I would compare what's returned by parse_form and parse_contents on this line.

It's one of the cumbersome things about this project that we are testing against so many html fixtures. Maybe Django provides a way to do less-whitespace-sensitive comparison of html?

[zerolab]

what happens when one passes just one or two instead of all 3 or no values?

[kbayliss]

Along with the changes that #29 adds, in both cases:

• if required=False: nothing
• if required=True and only one value is passed: separate ValidationErrors are raised for each individual field that's missing (e.g. "Please enter a month" and "Please enter a year" if only the day is provided)
• if required=True and no values are passed: separate ValidationErrors are raised for each individual field (e.g. "Please enter a month")

It's probably easier to look at the release branch for this with all of the changes combined: https://github.com/torchbox/tbxforms/pull/52/files#diff-e737fc521b5da51cd98b30ac80c551f4891fc4949dbf297f4da8b26b84490de1

[kbayliss]

This work has been merged as part of #52 (it was easier to do within an integration branch due to so many related changes)