-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get Tox Working #43
Get Tox Working #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start, thanks!
This config only runs the tests against Python 3.10. It is running all of the tox envs, but against 3.10. Check the output of the setup-python action - we only install 3.10. These lines also tell us what Python we're running
The reason this is running all of the envs anyway is that the py$VERSION
factors must be in the format pyNM
for tox to recognise them as interpreter versions, not py-NM
as we have here. https://tox.wiki/en/latest/user_guide.html#test-environments is the relevant section of the tox docs.
We need a matrix to run the tests once for each Python version.
The wagtail-localise config might be helpful. They use tox-gh-actions which we could consider. The relevant files are:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive-by review with a couple of notes/suggestions.
Feel free to ignore for a future PR
9f37f51
to
f31a2b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also update the changelog please?
This PR addresses issue #37
The aim is to use tox to run tests across all variations of Django versions 2.2 - 4.0 and Python versions 3.8 - 3.10.
This PR will enable: