Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the nested styling from tbxforms components #49

Closed
wants to merge 1 commit into from

Conversation

helenb
Copy link
Member

@helenb helenb commented May 19, 2023

This means that when styles for tbxforms components are being updated in projects, we don't have nested styling to override. See #40

Note that due to not currently having a local set-up where I can test this, this will need testing as well as code-reviewing.

@helenb helenb requested a review from kbayliss May 19, 2023 12:26
@helenb helenb self-assigned this May 19, 2023
@helenb
Copy link
Member Author

helenb commented May 19, 2023

I see that the test_python CI process has failed, but just to clarify this should be unrelated to my changes, which are only to CSS

@jams2
Copy link
Collaborator

jams2 commented May 19, 2023

Looks like we need to bump the poetry version (python-poetry/poetry#7878)

@helenb
Copy link
Member Author

helenb commented Aug 15, 2023

@kbayliss I see there's some activity happening on tbxforms at the moment. I don't have a local build any more (it was on my old laptop) - if you have a sec could you rebase and test this branch? It failed tests due to the poetry version but that must be fixed now if other branches are passing. thanks!

@kbayliss
Copy link
Collaborator

@helenb yep! I'll make sure it gets added to the release

@helenb
Copy link
Member Author

helenb commented Aug 15, 2023

@helenb yep! I'll make sure it gets added to the release

Thank you!

@kbayliss
Copy link
Collaborator

This work has been merged as part of #52 (it was easier to do within an integration branch due to so many related changes)

@kbayliss kbayliss closed this Aug 16, 2023
@kbayliss kbayliss linked an issue Aug 16, 2023 that may be closed by this pull request
@zerolab zerolab deleted the fix/remove-nested-styling branch August 16, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove nested styling inside the .tbxforms class
3 participants