Reuse our BaseForm class within tests and fix uncovered issues #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbayliss
commented
Aug 14, 2023
tests/layout/__snapshots__/test_checkboxes/test_change_legend_size.html
Outdated
Show resolved
Hide resolved
tests/layout/__snapshots__/test_checkboxes/test_show_legend_as_heading.html
Outdated
Show resolved
Hide resolved
tests/layout/__snapshots__/test_fieldset/test_show_legend_as_heading.html
Show resolved
Hide resolved
tests/layout/__snapshots__/test_file_upload/test_change_label_size.html
Outdated
Show resolved
Hide resolved
kbayliss
commented
Aug 15, 2023
tests/layout/__snapshots__/test_textarea/test_character_count.html
Outdated
Show resolved
Hide resolved
kbayliss
changed the title
zerolab
approved these changes
Aug 15, 2023
| @@ -11,7 +11,7 @@ | |||
| from wagtail.contrib.forms.forms import FormBuilder | |||
|
|
|||
|
|
|||
| class BaseForm: | |||
| class TbxFormsMixin: | |||
There was a problem hiding this comment.
will need to be highlighted in upgrade considerations
There was a problem hiding this comment.
Good shout, added: https://github.com/torchbox/tbxforms/releases
|
This work has been merged as part of #52 (it was easier to do within an integration branch due to so many related changes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #44
BaseFormwithin tests as opposed to testing arbitrary formsField.select()BaseFormtoTbxFormsMixinto more accurately convey what it is