Avoid using hardcoded localhost in Redirects #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakubMastalerz
force-pushed
the
feature/improve-redirect-handling
branch
2 times, most recently
from
8eeb2ab
to
f642999
Compare
JakubMastalerz
changed the title
kbayliss
requested changes
Dec 12, 2023
kbayliss
requested changes
Dec 19, 2023
JakubMastalerz
force-pushed
the
feature/improve-redirect-handling
branch
from
3356150
to
a003b5a
Compare
JakubMastalerz
force-pushed
the
feature/improve-redirect-handling
branch
from
75707b2
to
c5feca2
Compare
kbayliss
requested changes
Dec 19, 2023
kbayliss
reviewed
Jan 3, 2024
grapple/types/redirects.py
Outdated
Comment on lines
44
to
45
| class Meta: | ||
| name = "Redirect" |
There was a problem hiding this comment.
Can this be moved to just below the fields? I appreciate there isn't a standard way of doing that within this project (sometimes it's above the fields and sometimes it's below), though it's never at the end :).
There was a problem hiding this comment.
Addressed in c2a5365
|
@JakubMastalerz this is looking GREAT! As discussed earlier, can you review the performance of these changes to check we're not adversely affecting performance? In particular, I'm interested in the number of queries being made to ensure we're not causing any N+1 queries. |
kbayliss
approved these changes
Jan 5, 2024
kbayliss
force-pushed
the
feature/improve-redirect-handling
branch
from
6950794
to
12fd694
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
old_urlhandling inRedirectTypeto replace hardcoded URL generation with dynamically generated URLs based on wagtail'ssitesproperties.Additionally:
Redirecthad no specified target.The changes were tested for performance and did not increase the number of queries when querying
Redirects.