Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Title' column heading misaligned in explorer for users without 'publish' permission #1608

Closed
gasman opened this issue Aug 14, 2015 · 1 comment
Labels

Comments

@gasman
Copy link
Collaborator

gasman commented Aug 14, 2015

For users without publish permission, the 'order' column of the explorer is omitted. This results in the 'title' column heading being pushed too far to the left:
screen shot 2015-08-14 at 13 26 09

Rather than adding a special case in the CSS to give it an extra margin, I think it would be cleaner to consistently include the 'order' column all the time (and leave it blank for users without the relevant permission) - that way we avoid additional special-casing further down the line (e.g. #1583 (comment) - adding a row to contain a help message will require <td colspan="5"> or <td colspan="6">). This involves some rewiring of the table logic, though.

gasman added a commit to gasman/wagtail that referenced this issue Aug 14, 2015
@davecranwell davecranwell self-assigned this Aug 17, 2015
@kaedroho
Copy link
Contributor

PR: #1611

You should put the "fixes #1608" bit in the PR body text rather than the title so Github mentions it here.

@davecranwell davecranwell removed their assignment Aug 17, 2015
@gasman gasman closed this as completed in 1aa0f0b Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants