Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callable choices for ChoiceBlock #2809

Closed
m1kola opened this issue Jul 1, 2016 · 2 comments
Closed

Callable choices for ChoiceBlock #2809

m1kola opened this issue Jul 1, 2016 · 2 comments
Labels
type:Enhancement
Milestone
1.8

Comments

@m1kola
Copy link
Contributor

m1kola commented Jul 1, 2016

Would be nice to have support of callable choices for ChoiceBlock.

Django's ChoiceField supports callable values for choices argument since version 1.8.
@m1kola m1kola added this to the real-soon-now milestone Jul 1, 2016
m1kola added a commit to m1kola/wagtail that referenced this issue Jul 1, 2016
@m1kola
Add support of callable choices for ChoiceBlock
33fd526 
Fixes wagtail#2809
@m1kola m1kola mentioned this issue Jul 1, 2016
Closed
@m1kola m1kola modified the milestones: 1.6, real-soon-now Jul 1, 2016
@gasman gasman modified the milestones: 1.7, 1.6 Aug 1, 2016
@nkuttler
Copy link
Contributor

What is needed for this? Should I write some code and create a pull request? I really need this.

@m1kola
Copy link
Contributor Author

m1kola commented Aug 18, 2016

Hi @nkuttler.

We already have a pull request for this issue (see #2812). It would be great if you can do the code review and/or testing for your use case.

m1kola added a commit to m1kola/wagtail that referenced this issue Aug 26, 2016
@m1kola
Add support of callable choices for ChoiceBlock
63fff44 
Fixes wagtail#2809
@gasman gasman modified the milestones: 1.8, 1.7 Oct 5, 2016
@gasman gasman closed this as completed in 55bdae5 Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:Enhancement
Projects
None yet
Milestone
1.8
Development

No branches or pull requests
3 participants
@gasman @nkuttler @m1kola