-
Notifications
You must be signed in to change notification settings - Fork 168
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate the Trainer #115
Comments
I can start on this in about 2 weeks if nobody else gets on it :) |
What do you guys think of using pytorch-lightning to refactor the trainer? |
Yes, I looked at it a couple of days back. It provides a really good baseline to redesign our Having said that, I am still not comfortable with completely dropping the vanilla pytorch based trainer. Maybe we can shift to a |
I vote for fully dropping the current Currently we have:
We should move towards:
New stuff
Scaling training is handled by Do we move the |
LGTM only I think instead of doing The logger can then be moved to |
Background
TorchGAN started out with a primary focus on GANs. But recent literature has suggested that GANs are being used in time series modeling, NLP, etc. Hence the name
Trainer
sends the wrong message.Proposal
Trainer
andParallelTrainer
in v0.0.4 and completely remove them in v0.0.5+ImageTrainer
andParallelImageTrainer
which are exact copies of the current version ofTrainer
andParallelTrainer
.Trainer
s to broaden the scope of TorchGAN. RGAN and RCGAN implementation #110 discusses this.The text was updated successfully, but these errors were encountered: