Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix neighbor backward #179

Merged
merged 18 commits into from
Jun 14, 2023
Merged

Fix neighbor backward #179

merged 18 commits into from
Jun 14, 2023

Commits on May 30, 2023

  1. Fix two particles at the same location causing a NaN gradient

    @RaulPPelaez
    RaulPPelaez committed May 30, 2023
    Configuration menu
    Copy the full SHA
    d893656 View commit details
    Browse the repository at this point in the history

  2. Add test coverage

    @RaulPPelaez
    RaulPPelaez committed May 30, 2023
    Configuration menu
    Copy the full SHA
    d14a198 View commit details
    Browse the repository at this point in the history

  3. Update test

    @RaulPPelaez
    RaulPPelaez committed May 30, 2023
    Configuration menu
    Copy the full SHA
    6eca6d0 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. Implement backwards pass using pure pytorch to ensure double backwards 

    works
Add test for double backwards
    @RaulPPelaez
    RaulPPelaez committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    f0be694 View commit details
    Browse the repository at this point in the history

  2. Remove Autograd from C++ extension

    @RaulPPelaez
    RaulPPelaez committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    c564a46 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Remove backwards.cu

    @RaulPPelaez
    RaulPPelaez committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    0d92f29 View commit details
    Browse the repository at this point in the history

  2. Translate backwards to C++ so the module is compatible with jit.script 

    Write in full pytorch so autograd works in double gradient
Add test using gradcheck and gradgradcheck
    @RaulPPelaez
    RaulPPelaez committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    17691af View commit details
    Browse the repository at this point in the history

  3. Remove some unnecessary calls

    @RaulPPelaez
    RaulPPelaez committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    5734d87 View commit details
    Browse the repository at this point in the history

  4. Remove more unnecessary calls

    @RaulPPelaez
    RaulPPelaez committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    da5ab6b View commit details
    Browse the repository at this point in the history

  5. Compile OptimizedDistance only when it is used

    @RaulPPelaez
    RaulPPelaez committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    6207be4 View commit details
    Browse the repository at this point in the history

  6. Remove comment

    @RaulPPelaez
    RaulPPelaez committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    13228ac View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Replace Distance with OptimizedDistance in ET

    @RaulPPelaez
    RaulPPelaez committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    78d44d3 View commit details
    Browse the repository at this point in the history

  2. Update names in comment

    @RaulPPelaez
    RaulPPelaez committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    f298166 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary code

    @RaulPPelaez
    RaulPPelaez committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    5a49176 View commit details
    Browse the repository at this point in the history

  4. Revert "Replace Distance with OptimizedDistance in ET" 

    This reverts commit 78d44d3.
    @RaulPPelaez
    RaulPPelaez committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    8bc2833 View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary code

    @RaulPPelaez
    RaulPPelaez committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    5970fc0 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Pass strategy string as const ref

    @RaulPPelaez
    RaulPPelaez committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    dddb3b1 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Change variable name

    @RaulPPelaez
    RaulPPelaez committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    b9b6344 View commit details
    Browse the repository at this point in the history