Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable persistent_workers with num_workers=0 and disable pin_memory in DataModule #322

Merged
merged 2 commits into from
May 16, 2024

Conversation

sef43
Copy link
Collaborator

@sef43 sef43 commented May 16, 2024

currently I cannot set num_workers to zero:

ValueError:
persistent_workers option needs num_workers > 0

This was the fix suggested by @AntonioMirarchi that works for me

Closes #323
Closes #324

@RaulPPelaez RaulPPelaez changed the title enable num_workers=0 Disable persistent_workers with num_workers=0 and disable pin_memory in DataModule May 16, 2024
@RaulPPelaez
Copy link
Collaborator

Thanks @sef43, I remember setting that option already with @AntonioMirarchi, maybe it got lost in some pending PR.

@RaulPPelaez RaulPPelaez merged commit d8813f5 into torchmd:main May 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

persistent workers=True and Pinned memory=True is unstable cannot set num_workers=0
2 participants