Merge pull request #382 from torchsynth/feature/fix_floodir

Fix floordiv

torchsynth/synth.py

@@ -247,7 +247,22 @@ def _batch_idx_to_is_train(
             assert len(idxs) == self.batch_size
             # As specified in our paper, the first 9x1024 samples
             # are train, and the next 1024 are test.
-            is_train = (idxs // N_BATCHSIZE_FOR_TRAIN_TEST_REPRODUCIBILITY) % 10 != 9
+            # __floordiv__ is deprecated, and its behavior will
+            # change in a future version of pytorch. It currently
+            # rounds toward 0 (like the 'trunc' function NOT 'floor').
+            # This results in incorrect rounding for negative values.
+            # To keep the current behavior, use torch.div(a, b,
+            # rounding_mode='trunc'), or for actual floor division,
+            # use torch.div(a, b, rounding_mode='floor').
+            is_train = (
+                torch.div(
+                    idxs,
+                    N_BATCHSIZE_FOR_TRAIN_TEST_REPRODUCIBILITY,
+                    rounding_mode="trunc",
+                )
+                % 10
+                != 9
+            )
         else:
             is_train = None
         return is_train