New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating torch.range to torch.arange #378
Conversation
Yeah but what about older versions of pytorch? Do we break them? We should run a full jenkins |
Since when is it deprecated? Do you have a link? |
@turian |
Okay. Why are tests still breaking? |
Tests were breaking because the deprecated function call |
This pull request introduces 1 alert when merging 395c6ab into 23d6411 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## main #378 +/- ##
==========================================
- Coverage 97.06% 96.68% -0.39%
==========================================
Files 10 9 -1
Lines 887 694 -193
==========================================
- Hits 861 671 -190
+ Misses 26 23 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
torch.range
is now deprecated and should be replaced withtorch.arange
, which is consistent with pythons built-in range.torch.range
also was producing errors with high-valued ranges, see #377Merge #380 into this first.