Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow lightning 1.x #434

Open
turian opened this issue Dec 15, 2023 · 0 comments
Open

Allow lightning 1.x #434

turian opened this issue Dec 15, 2023 · 0 comments

Comments

@turian
Copy link
Collaborator

turian commented Dec 15, 2023

88bda58

I don't love this solution. We put a LOT of effort into cross testing the code for many python versions and pytorch lightning versions, so that we wouldn't be like those tf 1.x people.

If you download the package and have lightning 2.0, changing one line is an inconvenience. If you download the package and have lightnign 1.x, downporting it is definitely scary business because you don't know if there will be a regression.

I propose:
a) Put back all the testing for all the older versions
b) Do a try except block to first try lightning and the pl
c) Since we don't use lightning, and also hacking torchsynth to work with lightning is janky (I can show you my code and what I'm doing), we consider actually making a torchsynth-lightning package and getting rid of the lightning dep, with nicer lightning wrapping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant