Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-continue & replacement by popup #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MathieuNls
Copy link

Hi,

First of all, thanks for your package.

  • I found that the option for automatic replacement replaceOriginal is good but it doesn't allow to check the modification before accepting them. It just replace. So, I've made an option popupCorrection that will display a confirm dialog. If the user hit ok then, the original text is replaced. This could be nicer by using the NotificationManager of Atom, but it works.
  • I was frustrated that I had to hit ctrl + shift + g for each sentence, so I created an option continue that automatically moves the cursor to the next sentence and run the correct function. It stops only between paragraphs.

M.

@toricls
Copy link
Owner

toricls commented Nov 7, 2015

Thanks for your contribution. I'll take a look soon 😃

@toricls
Copy link
Owner

toricls commented Nov 11, 2015

Let me ask you a question.

What did you expected about how this plugin behave if users use this plugin with following options?

  • replaceOriginal: false
  • continue: true
  • popupCorrection: true

Or if you didn't intend such a usage, I think the implementation should handle status about each options in keeping with your expectation.

And please write some tests to keep this plugin's decent quality.

Thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants