Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 2* #10

Closed
torifat opened this issue Jan 4, 2021 · 10 comments
Closed

Add support for 2* #10

torifat opened this issue Jan 4, 2021 · 10 comments
Labels
enhancement New feature or request

Comments

@torifat
Copy link
Owner

torifat commented Jan 4, 2021

The fork of miio introduced some new method name hence 2* devices might not work. Streamline the method names in my fork https://github.com/torifat/miio so that 2* devices work.

@torifat torifat added the enhancement New feature or request label Jan 4, 2021
@ifeign
Copy link

ifeign commented Jan 4, 2021

Is this why I can't control the child lock on my Mi Purifier 2?

@torifat
Copy link
Owner Author

torifat commented Jan 5, 2021

@ifeign I believe so. Is everything else working for you?

@ifeign
Copy link

ifeign commented Jan 10, 2021

I'll do an extensive test of this asap

@r2binx
Copy link

r2binx commented Jan 13, 2021

It's not working on my 2H unfortunately. It doesn't seem to get any data.
Couldn't really find anything useful in the log.

@heikobischoff
Copy link

heikobischoff commented Jan 30, 2021

I cannot control the fan speed on my AirPurifier 2 as well. Child lock I didn't try. On/Off and sensor data are working for me. Would be great to support fan speed, too. I can support with testing if required.

Edit: I discovered an issue, maybe related to this issue as well. When I open my Home app, I can see all telemetry data from the Purifier:
Screenshot 2021-01-30 at 01 20 39
After turning it off and on again, I see "no response":
Screenshot 2021-01-30 at 01 22 36
I am still able to turn it off and on, but instead of the data I only can see "no response".
In the climate of this room, I am still able to see the data provided by the plugin:
Screenshot 2021-01-30 at 01 23 28
The icon of the accessory is marked with an exclamation mark:
Screenshot 2021-01-30 at 01 23 32
After restarting the app, the data is coming back on the accessory info. Behaviour is the same on iOS and macOS.

Edit #2: Filter condition is not reported, too. It shows only "Unknown".

@pax0707
Copy link

pax0707 commented Mar 1, 2021

Same with 2S.

@cbrunnkvist
Copy link
Contributor

I use the Mi Air Purifier 2S model. I changed to this plugin from the my previous homebridge-xiaomi-purifier-eu (repo) because that was bombarding my log with "Lock Physical Controls" read handler errors.

But it does not make anything better: now I get flooded logs again, but this time with an error related to Filter Life Level and Filter Change Indication instead and I don't think any controls work:

2021-11-22, 12:06:21 PM [Raspberry-HOOBS 1F84@Air Purifier 2@Air Quality on Air Purifier 2@Filter Life Level] Unhandled error thrown inside read handler for characteristic: Cannot read property 'value' of undefined
2021-11-22, 12:06:21 PM [Raspberry-HOOBS 1F84@Air Purifier 2@Air Quality on Air Purifier 2@Filter Change Indication] Unhandled error thrown inside read handler for characteristic: Cannot read property 'value' of undefined

😩

@torifat
Copy link
Owner Author

torifat commented Nov 22, 2021

@cbrunnkvist I will fix this soon. Please follow #229

@cbrunnkvist
Copy link
Contributor

cbrunnkvist commented Nov 23, 2021

I compared what is presented in the Home app for the 2S and I can confirm that I also miss the speed control slider that is presented by the legacy module. Now I only see the power toggle alone, just like @heikobischoff's screenshot.

@torifat
Copy link
Owner Author

torifat commented Nov 23, 2021

Closing this since we are also discussing the same thing in #229 (comment). I will take care of the fan speed problem soon.

@torifat torifat closed this as completed Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants