Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove framedelay #1

Merged
merged 5 commits into from
Jul 14, 2023
Merged

Remove framedelay #1

merged 5 commits into from
Jul 14, 2023

Conversation

tebjan
Copy link

@tebjan tebjan commented Jul 14, 2023

This PR improves two things:

  • The shadow data is retrieved in the same frame in the draw call before drawing the shadow catcher
  • The custom scene nodes aren't necessary because the show maps can be retrieved from the RenderContext in the draw call too

@tebjan tebjan marked this pull request as ready for review July 14, 2023 13:56
@tebjan
Copy link
Author

tebjan commented Jul 14, 2023

Ready for merging from my end. But please review it to ensure it still functions correctly...

@torinos-yt torinos-yt merged commit 492feee into torinos-yt:main Jul 14, 2023
@torinos-yt
Copy link
Owner

Merged. It seems to be working correctly at hand. Thanks for the great PR!. I still don't know much about stride :D

@tebjan
Copy link
Author

tebjan commented Jul 14, 2023

It looks impressive what you did with the shadow maps and reflection, it shows deep insight. Using the render context as information storage isn't documented anywhere, so it is super hard to find. Now you know it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants