Add non-NULL asserts to CMSG_* returns, null-initialize AncillaryBuf #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tormol
reviewed
Aug 7, 2023
src/ancillary.rs
Outdated
| @@ -119,14 +119,29 @@ pub fn send_ancillary( | |||
| } | |||
|
|
|||
| #[cfg(not(any(target_os="illumos", target_os="solaris")))] { | |||
| let mut header = &mut*CMSG_FIRSTHDR(&mut msg); | |||
| let header_ptr = CMSG_FIRSTHDR(&mut msg); | |||
| if header_ptr.is_null() { | |||
There was a problem hiding this comment.
This can only happen as result of a bug, so an assert or debug_assert would be better.
Speaking of bugs, I see CMSG_SPACE() not CMSG_LEN() should be used to calculate the size, so this could happen. But I can fix that.
|
I've fixed the CI failure, please rebase. |
domenukk
changed the title
|
Rebased and switched to |
domenukk
changed the title
|
Thanks! |
tormol
pushed a commit
that referenced
this pull request
Aug 13, 2023
CMSG_FIRSTHDR() and CMSG_NXTHDR() expect the buffer to be zero-initialized. Also assert that these functions don't return NULL
|
Released as 0.2.7 and 0.3.0. |
This was referenced Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two checks for NULL returns and one zero-ing that is technically more correct