Skip to content

Commit

Permalink
test: Close a websocket client that causes occasional test failures
Browse files Browse the repository at this point in the history
These failures occur on the build.yml workflow on the emulated arm64
platform: an ill-timed timer firing during test shutdown can result
in a message being logged and the test failing for dirty logs.
  • Loading branch information
bdarnell committed Apr 24, 2023
1 parent fcb09eb commit 1849ef6
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tornado/test/websocket_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -807,6 +807,7 @@ def test_client_ping(self):
response = yield ws.read_message()
self.assertEqual(response, "got ping")
# TODO: test that the connection gets closed if ping responses stop.
ws.close()


class ManualPingTest(WebSocketBaseTestCase):
Expand Down

0 comments on commit 1849ef6

Please sign in to comment.