ioloop: Annotate run_in_executor returning Future, not Awaitable

This required a recent update to typeshed/mypy. Fixes #3093
tornadoweb · Jul 27, 2023 · 6a0af16 · 6a0af16
1 parent 8bfa66a
commit 6a0af16
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/tornado/ioloop.py b/tornado/ioloop.py
@@ -711,7 +711,7 @@ def run_in_executor(
         executor: Optional[concurrent.futures.Executor],
         func: Callable[..., _T],
         *args: Any
-    ) -> Awaitable[_T]:
+    ) -> Future[_T]:
         """Runs a function in a ``concurrent.futures.Executor``. If
         ``executor`` is ``None``, the IO loop's default executor will be used.
 

diff --git a/tornado/platform/asyncio.py b/tornado/platform/asyncio.py
@@ -37,7 +37,6 @@
 
 from typing import (
     Any,
-    Awaitable,
     Callable,
     Dict,
     List,
@@ -237,7 +236,7 @@ def run_in_executor(
         executor: Optional[concurrent.futures.Executor],
         func: Callable[..., _T],
         *args: Any,
-    ) -> Awaitable[_T]:
+    ) -> asyncio.Future[_T]:
         return self.asyncio_loop.run_in_executor(executor, func, *args)
 
     def set_default_executor(self, executor: concurrent.futures.Executor) -> None: