auth: Facebook now returns auth tokens in json instead of url-encoded

Fixes #1992
tornadoweb · Mar 30, 2017 · 8bb8795 · 8bb8795
1 parent c0f99ba
commit 8bb8795
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/tornado/auth.py b/tornado/auth.py
@@ -978,9 +978,9 @@ def _on_access_token(self, redirect_uri, client_id, client_secret,
             future.set_exception(AuthError('Facebook auth error: %s' % str(response)))
             return
 
-        args = urlparse.parse_qs(escape.native_str(response.body))
+        args = escape.json_decode(response.body)
         session = {
-            "access_token": args["access_token"][-1],
+            "access_token": args.get("access_token"),
             "expires": args.get("expires")
         }
 

diff --git a/tornado/test/auth_test.py b/tornado/test/auth_test.py
@@ -149,7 +149,7 @@ def get(self):
 
 class FacebookServerAccessTokenHandler(RequestHandler):
     def get(self):
-        self.write('access_token=asdf')
+        self.write(dict(access_token="asdf"))
 
 
 class FacebookServerMeHandler(RequestHandler):