Make Resolver's callback argument optional when the Future result is …

…used.
tornadoweb · Feb 18, 2013 · b605c0a · b605c0a
1 parent 21acd09
commit b605c0a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/tornado/concurrent.py b/tornado/concurrent.py
@@ -105,7 +105,7 @@ def submit(self, fn, *args, **kwargs):
 def run_on_executor(fn):
     @functools.wraps(fn)
     def wrapper(self, *args, **kwargs):
-        callback = kwargs.pop("callback")
+        callback = kwargs.pop("callback", None)
         future = self.executor.submit(fn, self, *args, **kwargs)
         if callback:
             self.io_loop.add_future(future, callback)

diff --git a/tornado/test/netutil_test.py b/tornado/test/netutil_test.py
@@ -3,7 +3,7 @@
 import socket
 
 from tornado.netutil import BlockingResolver, ThreadedResolver
-from tornado.testing import AsyncTestCase
+from tornado.testing import AsyncTestCase, gen_test
 from tornado.test.util import unittest
 
 try:
@@ -27,6 +27,17 @@ def test_localhost(self):
              ('127.0.0.1', 80)),
             future.result())
 
+    @gen_test
+    def test_future_interface(self):
+        addrinfo = yield self.resolver.getaddrinfo(
+            'localhost', 80, socket.AF_UNSPEC,
+            socket.SOCK_STREAM, socket.IPPROTO_TCP)
+        self.assertIn(
+            (socket.AF_INET, socket.SOCK_STREAM, socket.IPPROTO_TCP, '',
+             ('127.0.0.1', 80)),
+            addrinfo)
+
+
 
 class BlockingResolverTest(AsyncTestCase, _ResolverTestMixin):
     def setUp(self):