Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly parse If-None-Match header #1218

Closed
bdarnell opened this issue Oct 11, 2014 · 0 comments · Fixed by #1274
Closed

Correctly parse If-None-Match header #1218

bdarnell opened this issue Oct 11, 2014 · 0 comments · Fixed by #1274
Labels
web

Comments

@bdarnell
Copy link
Member

We currently just look for the current Etag as a substring of If-None-Match, which mostly works for our hash-generated Etags (although it did mask a bug involving str() on a bytes object in python 3), but is not guaranteed to be correct for applications that override compute_etag.
@daftshady daftshady mentioned this issue Dec 12, 2014
Merged
@bdarnell bdarnell added the web label Jan 12, 2015
bdarnell added a commit that referenced this issue Mar 6, 2015
@bdarnell
Merge pull request #1274 from daftshady/etag
9a8a98e 
Fixed #1218.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
web
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed #1218. daftshady/tornado
1 participant
@bdarnell