OAuth2

[FanFani4]

Hello,
this fixes the GoogleOAuth2Mixin.get_authenticated_user, in docstring it said that its returning a user object but really it returns the access token.
and i added some popular russian socials as mail.ru, vk.com, yandex.ru.

[bdarnell]

The addition of google_request seems like a good idea (can the implementation be shared with FacebookGraphMixin's facebook_request?).

The change to get_authenticated_user is backwards-incompatible, right? I think it's probably better to change the documentation to match what it already returns than to change the implementation at this point.

I don't want to add any more specific auth providers to this module; it's better to let those live outside of the main Tornado repo. (see #236)

[FanFani4]

Hello,
can you please see if i understand you correctly?
in docstring of get_authenticated_user already is said that:
Handles the login for the Google user, returning a user object

[bdarnell]

Yes, if get_authenticated_user returns an access token instead of a user object, then the docs should be updated to say that.

It looks like you've replaced facebook_request with a new auth_request method; there needs to be a facebook_request method for backwards-compatibility even if it's just a wrapper around auth_request.

This functionality should also have tests.

[kippandrew]

@bdarnell I noticed the GoogleOAuth2Mixin.get_authenticated_user method is still broken, or at the very least is incorrectly documented (it returns an access_token instead of the user's profile). I'm happy to fix this, but I am wondering what your preferred approach is? I can open another PR (or fix this one) with a factored out auth_request. Or did you have something else in mind? Like are you planning on removing all the OAuth stuff all-together?

[bdarnell]

I've committed a change to update the docs for get_authenticated_user (and incorporated some of the other changes in this branch).