Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Start release notes for 5.0. #2219

Merged
merged 5 commits into from
Dec 18, 2017
Merged

Conversation

bdarnell
Copy link
Member

Update versionadded/versionchanged tags. Misc other doc updates

PR tornadoweb#1984 was based on the mistaken belief that we were already
doing this (and in python 3.4+, it's true, thanks to PEP 446). This
fixes a regression introduced in Tornado 4.5 in which autoreload would
leak file descriptors and leave client connections hanging.

Fixes tornadoweb#2057
Update versionadded/versionchanged tags. Misc other doc updates
@bdarnell bdarnell merged commit 268aaf6 into tornadoweb:master Dec 18, 2017
@bdarnell bdarnell deleted the release-notes branch December 18, 2017 03:35
@jakirkham
Copy link

Given Python 2 support is on its way out, would suggest adding Tornado to python3statement. Admittedly this has mostly focused on the Scientific Python stack. Though there is no reason it should be limited to those Python packages. Not to mention many Scientific Python libraries make use of Tornado. So this would be good info to have there.

@bdarnell
Copy link
Member Author

Thanks for the suggestion; I've added a comment to python3statement/python3statement.github.io#21.

@mscuthbert
Copy link

Since I see that @bdarnell has left an open "TODO" for the Q of dropping Python 2 earlier rather than later, my recommendation is to go for it. I manage a much smaller but still substantial project (music21 -- about 700 people on the mailing list) and while I expected some pushback, there was nary a squeak from users when the first Py3 only versions started coming out. One grumble received personally then an hour later an email, "Oh! Feature X is 10x faster in the new version. Okay, I'll switch to Py3" Feature X was something I had never bothered to optimize because it was so hard to make work the same in Py2 and Py3; once I dropped Py2, that feature, and indeed the whole project, became a joy to work on again. I can't imagine that anyone working extensively with async code wouldn't experience that joy ten-fold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants