Allow custom resolver in WebSocketClientConnection #3172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @bdarnell |
|
I don't want to nag - I know how annoying requests like this can be - but I'd be interested to know if you're thinking of doing another release (presumably 6.3) soon, or whether it's likely to be still some months away? Thanks! 🙂 |
|
Unfortunately I don't have much time for Tornado these days, so barring some major issue, the next release is unlikely to be "soon". Even "some months" sounds optimistic given my current schedule - 6.1 and 6.2 were over 18 months apart. |
|
No problem, thanks for letting me know. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimpleAsyncHTTPClientaccepts a customresolverinstance, and this can be used to make an HTTP connection to Unix sockets (see also #2671). I would like to do the same with WebSocketClientConnection. It's possible by globally configuring the resolver class, but I'd prefer to do it without global side-effects.For more context, this is part of an effort for jupyter-server-proxy to support proxying services listening securely on Unix sockets, as well as TCP sockets (jupyterhub/jupyter-server-proxy#337 ). This is currently working apart from Websocket support, which this PR would make possible.