Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve contextvars context when handle httpclient response #3340

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Preserve contextvars context when handle httpclient response #3340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tornado/httpclient.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
AsyncHTTPClient.configure("tornado.curl_httpclient.CurlAsyncHTTPClient")
"""

import contextvars
import datetime
import functools
from io import BytesIO
Expand Down Expand Up @@ -303,7 +304,12 @@ def handle_response(response: "HTTPResponse") -> None:
return
future_set_result_unless_cancelled(future, response)

self.fetch_impl(cast(HTTPRequest, request_proxy), handle_response)
context = contextvars.copy_context()

self.fetch_impl(
cast(HTTPRequest, request_proxy),
lambda response: context.run(handle_response, response),
)
return future

def fetch_impl(
Expand Down