100% CPU with SSL fix #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you reproduce this with a simple test case? It's always good to get more test cases for platform-specific behavior, but if it's difficult to reproduce don't worry about it. |
bdarnell
added a commit
that referenced
this pull request
Jun 29, 2012
Fix SSL error handling bug that could result in 100% cpu usage. Possibly platform-specific; observed on windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When some connection was reset Tornado started to use 100% of CPU. That was caused by not closed socket which constantly generated socket.error with errno.ECONNRESET code instead handled errno.ECONNABORTED.
Platform the error detected: windows. However other platforms probably affected too.