Skip to content

Add support for cookies on redirects for the simple_httpclient #602

Open
wants to merge 1 commit into from

2 participants

@ierror
ierror commented Oct 3, 2012

some sites do redirects or interrupt them based on cookies.

@bdarnell
tornadoweb member
bdarnell commented Oct 4, 2012

Cookies should only be sent if the domains match (among other requirements). Trying to emulate browser policies here seems tricky, so any cookie support should be opt-in (and perhaps based on a pluggable policy object; see the standard library's cookielib for example).

Please add a test for this change (and fix the tests that are failing on python 3).

@bdarnell bdarnell added the httpclient label Jul 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.