Switching from get_unused_port to bind_unused_port in ClientTextMixin class. #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… class. bind_unused_port guarantees that it will find an unused port for testing purposes. get_unused_port was causing tests to fail due to a port already being in use on a development machine (in this case, a mac running osx 10.8).
|
Whoops, I thought I had fixed all of those. Anyway, as the CI build shows, you need to actually use the socket returned by bind_unused_port, since it won't be available if you just try to bind it again. I'll make a separate commit with the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bind_unused_port guarantees that it will find an unused port for testing purposes. get_unused_port was causing tests to fail due to a port already being in use on a development machine (in this case, a mac running osx 10.8).