Switching from get_unused_port to bind_unused_port in ClientTextMixin class. #676

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@jpittman

bind_unused_port guarantees that it will find an unused port for testing purposes. get_unused_port was causing tests to fail due to a port already being in use on a development machine (in this case, a mac running osx 10.8).

@jpittman jpittman Switching from get_unused_port to bind_unused_port in ClientTextMixin…
… class.

bind_unused_port guarantees that it will find an unused port for testing purposes.  get_unused_port was causing tests to fail due to a port already being in use on a development machine (in this case, a mac running osx 10.8).
27f7bd6
@bdarnell bdarnell closed this in 172e095 Feb 6, 2013
@bdarnell
tornadoweb member

Whoops, I thought I had fixed all of those. Anyway, as the CI build shows, you need to actually use the socket returned by bind_unused_port, since it won't be available if you just try to bind it again. I'll make a separate commit with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment