Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option xsize has no effect with certain commands and options (fastx_filter and chimeras) #272

Closed
frederic-mahe opened this issue Oct 22, 2017 · 5 comments
Assignees
Labels

Comments

@frederic-mahe
Copy link
Collaborator

According to the vsearch -h command, the option --xsize removes the abundance annotation from fastq/fasta headers. But it has no effect when used with --fastx_filter (with vsearch 2.5.0):

vsearch --fastx_filter <(printf "@s;size=1;\nA\n+\nI\n") --xsize --fastqout - 2> /dev/null

returns:

@s;size=1;
A
+
I
@gregcaporaso
Copy link

gregcaporaso commented Dec 15, 2017

I'm also noticing this with the --chimeras output (but not the --nonchimeras output) for both --uchime_ref and --uchime_denovo.

$ vsearch --uchime_ref    seqs-w-sizes.fasta --uchimeout out.tsv \
 --nonchimeras nonchim.fna --chimeras chime.fna --dn 1.4 --mindiffs 3 --mindiv 0.8 \
 --minh 0.28 --xn 8.0 --xsize --qmask none --db 76-otus/dna-sequences.fasta --quiet

$ head -1 chime.fna
>chime2;size=1

$ head -1 nonchim.fna
>eb3564a35320b53cef22a77288838c7446357327
$ vsearch --uchime_denovo    seqs-w-sizes.fasta --uchimeout out.tsv \
 --nonchimeras nonchim.fna --chimeras chime.fna --dn 1.4 --mindiffs 3 \
 --mindiv 0.8 --minh 0.28 --xn 8.0 --xsize --qmask none --quiet

$ head -1 chime.fna
>chime1;size=1

$ head -1 nonchim.fna
>e84fcf85a6a4065231dcf343bb862f1cb32abae6

It also looks like the abundance information is retained in the --uchimeout. It would be helpful for my application if --xsize impacted that as well. For example, a line in out.tsv from my uchime_ref command above:

0.0384	fd7a7221db15d82dbea087a1ecb66ce871978e7b;size=4	268769	516290	268769	84.2	82.7	75.5	66.9	82.7	17	54	10	8	5	1.4	N

@torognes torognes self-assigned this Dec 15, 2017
@torognes torognes added the bug label Dec 15, 2017
@torognes torognes changed the title option xsize has no effect when used with the command fastx_filter option xsize has no effect with certain commands and options (fastx_filter and chimeras) Dec 15, 2017
@torognes
Copy link
Owner

I plan to fix this on Monday 18 Dec.

@torognes
Copy link
Owner

The reported problems should be fixed in release 2.6.2. I suspect the problems may apply to other commands than fastx_filter, uchime_denovo and uchime_ref, so I will keep the issue open until I have checked that out. The code involved also needs some refactoring.

@gregcaporaso
Copy link

Thanks for the quick response @torognes!

@torognes
Copy link
Owner

Fixed in version 2.7.0 just released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants