Skip to content

Commit

Permalink
Merge remote-tracking branch 'tor-github/pr/1432' into maint-0.4.2
Browse files Browse the repository at this point in the history
  • Loading branch information
teor2345 committed Oct 20, 2019
2 parents 5c8ecf3 + 0a5ce82 commit 5dbdca0
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions src/lib/err/backtrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ static pthread_mutex_t cb_buf_mutex = PTHREAD_MUTEX_INITIALIZER;

/** Lock and return a static stack pointer buffer that can hold up to
* MAX_DEPTH function pointers. */
static void *
static void **
lock_cb_buf(void)
{
/* Lock the mutex first, before even declaring the buffer. */
Expand All @@ -102,7 +102,7 @@ lock_cb_buf(void)

/** Unlock the static stack pointer buffer. */
static void
unlock_cb_buf(void *cb_buf)
unlock_cb_buf(void **cb_buf)
{
memset(cb_buf, 0, SIZEOF_CB_BUF);
pthread_mutex_unlock(&cb_buf_mutex);
Expand Down Expand Up @@ -149,7 +149,7 @@ log_backtrace_impl(int severity, log_domain_mask_t domain, const char *msg,
char **symbols;
size_t i;

void *cb_buf = lock_cb_buf();
void **cb_buf = lock_cb_buf();

depth = backtrace(cb_buf, MAX_DEPTH);
symbols = backtrace_symbols(cb_buf, (int)depth);
Expand Down Expand Up @@ -183,7 +183,7 @@ crash_handler(int sig, siginfo_t *si, void *ctx_)
int n_fds, i;
const int *fds = NULL;

void *cb_buf = lock_cb_buf();
void **cb_buf = lock_cb_buf();

(void) si;

Expand Down Expand Up @@ -214,7 +214,7 @@ dump_stack_symbols_to_error_fds(void)
const int *fds = NULL;
size_t depth;

void *cb_buf = lock_cb_buf();
void **cb_buf = lock_cb_buf();

depth = backtrace(cb_buf, MAX_DEPTH);

Expand Down Expand Up @@ -256,7 +256,7 @@ install_bt_handler(void)
* libc has pre-loaded the symbols we need to dump things, so that later
* reads won't be denied by the sandbox code */
char **symbols;
void *cb_buf = lock_cb_buf();
void **cb_buf = lock_cb_buf();
size_t depth = backtrace(cb_buf, MAX_DEPTH);
symbols = backtrace_symbols(cb_buf, (int) depth);
if (symbols)
Expand Down

0 comments on commit 5dbdca0

Please sign in to comment.