Ticket31684 #1328
Closed
Ticket31684 #1328
Conversation
Pull Request Test Coverage Report for Build 6594
|
ltbringer
force-pushed
the
Ticket31684
branch
5 times, most recently
from
683cb91
to
eca91ff
- Allows control port to read microdesc consensus using: GETINFO dir/status-vote/microdesc/consensus refer: [ticket](https://trac.torproject.org/projects/tor/ticket/31684) refer: [comment](https://trac.torproject.org/projects/tor/ticket/31684#comment:6) add: Helper function `getinfo_helper_current_consensus` add(changes/ticket31684): track changes within ticket31684 fix(changes/ticket31684): formatting and ticket#number refactor: remove redundant conditionals fix: getinfo_helper_current_consensus returns -1 for any question that doesn't ask for microdesc or ns descriptors lint: wide condition
asn-d6
requested changes
Sep 26, 2019
OK here is a review. Also please change the commit message to specify what the changes did, instead of which trac ticket they fixed. Example "Add GETINFO support for dumping microdesc consensus".
asn-d6
reviewed
Sep 26, 2019
asn-d6
reviewed
Sep 27, 2019
asn-d6
reviewed
Sep 27, 2019
ltbringer
force-pushed
the
Ticket31684
branch
8 times, most recently
from
3d18911
to
e8a060d
asn-d6
reviewed
Sep 30, 2019
asn-d6
reviewed
Sep 30, 2019
asn-d6
reviewed
Sep 30, 2019
asn-d6
reviewed
Sep 30, 2019
asn-d6
reviewed
Sep 30, 2019
ltbringer
force-pushed
the
Ticket31684
branch
3 times, most recently
from
8f3a3f1
to
e546a6a
teor2345
reviewed
Oct 2, 2019
teor2345
reviewed
Oct 2, 2019
teor2345
reviewed
Oct 2, 2019
teor2345
reviewed
Oct 2, 2019
teor2345
reviewed
Oct 2, 2019
teor2345
reviewed
Oct 2, 2019
ltbringer
force-pushed
the
Ticket31684
branch
7 times, most recently
from
42149a2
to
5b34a4d
|
It seems like you're pushing a lot of commits here. Or maybe this task isn't a good fit for you. |
|
I'll take it off on a separate branch and use the CI on my fork. I assumed I'd get this done faster but I should have done this before. Sincere apologies. |
asn-d6
requested changes
Oct 7, 2019
ltbringer
force-pushed
the
Ticket31684
branch
2 times, most recently
from
a4ebfbc
to
933ea85
test: check if GETINFO commands return expected consensus data.. docs: function docs easier to understand update: Code simplification and refactoring change
asn-d6
reviewed
Oct 10, 2019
asn-d6
reviewed
Oct 10, 2019
…nd type of getinfo_helper_current_consensus accepts flavor as a type(enum) consensus_flavor_t instead of plain int lint: removed unnecessary line
teor2345
reviewed
Oct 21, 2019
| (int flav, | ||
| const char *flavorname, | ||
| int unverified_consensus)); | ||
| tor_mmap_t * networkstatus_map_cached_consensus(const char *flavorname); |
Extra space
| { | ||
| const char *flavor_name = networkstatus_get_flavor_name(flavor); | ||
| if (!strcmp(flavor_name, "??")) { | ||
| *errmsg = "Could not open cached consensus. " |
Wrong error message
| return -1; | ||
| } | ||
| } |
Weird spacing?
| @@ -1513,6 +1544,8 @@ static const getinfo_item_t getinfo_items[] = { | |||
| "v2 networkstatus docs as retrieved from a DirPort."), | |||
| ITEM("dir/status-vote/current/consensus", dir, | |||
| "v3 Networkstatus consensus as retrieved from a DirPort."), | |||
| ITEM("dir/status-vote/current/consensus-microdesc", dir, | |||
| "v3 Microdescriptors consensus as retrieved from a DirPort."), | |||
Typo
| dirserv_get_consensus(const char *flavor_name) | ||
| MOCK_IMPL(cached_dir_t *, | ||
| dirserv_get_consensus, | ||
| (const char *flavor_name)) |
Spacing
| } else if (!strcmp(question, "dir/status-vote/current/consensus")) { | ||
| int consensus_result = getinfo_helper_current_consensus(FLAV_NS, | ||
| answer, errmsg); | ||
| if (consensus_result == -1) { |
We use < 0
| const char *errmsg = NULL; | ||
|
|
||
| (void)arg; | ||
| setup_bridge_mocks(); |
Not needed
| tor_free(mock_microdesc_consensus_cache->dir); | ||
| tor_free(answer); | ||
| errmsg = NULL; | ||
| options->FetchUselessDescriptors = previous_fetch_value; |
Should be after done:
| (void)arg; | ||
| setup_bridge_mocks(); | ||
| or_options_t *options = get_options_mutable(); | ||
| int previous_fetch_value = options->FetchUselessDescriptors; |
Not needed
| options->FetchUselessDescriptors = previous_fetch_value; | ||
|
|
||
| done: | ||
| clear_bridge_mocks(); |
Not needed
|
Latest code in #1434. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Add control port GETINFO support for dumping the local consensus
Refer: (ticket)[https://trac.torproject.org/projects/tor/ticket/31684]
The text was updated successfully, but these errors were encountered: