Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug24977 final #146

Closed
wants to merge 7 commits into from
Closed

Bug24977 final #146

wants to merge 7 commits into from

Commits on Jun 13, 2018

  1. Require live consensus to compute responsible HSDirs.

    Here is how this changes the HSv3 client-side and service-side:
    
    For service side we already required live consensus to upload descriptors (see
    9e900d1) so we should never get there without
    a live consensus.
    
    For the client-side we now require a live consensus to attempt to connect to
    HS.  While this changes the client behavior in principle, it doesn't really
    change it, because we always required live consensus to set HSDir indices, so
    before this patch a client with no live consensus would try to compute
    responsible HSDirs without any HSDir indices and bug out. This makes the client
    behavior more consistent, by requiring a live consensus (and hence a
    semi-synced clock) for the client to connect to an HS entirely.
    
    The alternative would have been to allow setting HSDir indices with a non-live
    consensus, but this would cause the various problems outlined by commit
    b89d2fa.
    asn-d6 committed Jun 13, 2018
    Copy the full SHA
    2520ee3 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    9988ac5 View commit details
    Browse the repository at this point in the history
  3. Recreate nodelist before use if it's outdated.

    We currently only do the check when we are about to use the HSDir indices.
    asn-d6 committed Jun 13, 2018
    Copy the full SHA
    784b7f7 View commit details
    Browse the repository at this point in the history
  4. Add changes file for #24977.

    asn-d6 committed Jun 13, 2018
    Copy the full SHA
    e7e5875 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2018

  1. Copy the full SHA
    aa951c7 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    222c5cf View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    82bb4f3 View commit details
    Browse the repository at this point in the history