Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract relay dns #1752

Merged
merged 6 commits into from Feb 19, 2020
Merged

Extract relay dns #1752

merged 6 commits into from Feb 19, 2020

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmathewson @coveralls @torproject-pusher
@nmathewson
Copy link
Contributor

@nmathewson nmathewson commented Feb 18, 2020

No description provided.

nmathewson added 3 commits Feb 18, 2020
@nmathewson
Replace identifiers related to clipping DNS ttls.
dcbc45e 
This is an automated commit, generated by this command:

./scripts/maint/rename_c_identifier.py \
        MIN_DNS_TTL_AT_EXIT MIN_DNS_TTL \
        MAX_DNS_TTL_AT_EXIT MAX_DNS_TTL \
        dns_clip_ttl clip_dns_ttl
@nmathewson
Move DNS TTL manipulation code to src/core/or
1f06f49 
This removes a dependency from the client code on feature/relay.
@nmathewson
Disable dns.c when relay mode is disabled.
c43a245 
This saves about 1% for me on a binary compiled without relay mode.

Closes ticket 33366.
@coveralls
Copy link

@coveralls coveralls commented Feb 18, 2020 •
edited

Pull Request Test Coverage Report for Build 8165

  • 4 of 11 (36.36%) changed or added relevant lines in 3 files are covered.
  • 22 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.004%) to 63.412%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/or/connection_edge.c 4 5 80.0%
src/feature/client/addressmap.c 0 1 0.0%
src/feature/relay/dns.c 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
src/feature/hs/hs_common.c 1 84.27%
src/core/or/scheduler_kist.c 9 79.76%
src/core/or/scheduler.c 12 84.44%
Totals Coverage Status
Change from base Build 8142: 0.004%
Covered Lines: 50017
Relevant Lines: 78876
💛 - Coveralls

nmathewson added 3 commits Feb 19, 2020
@nmathewson
dns.h: label functions that are only used inside feature/relay
51b470d
@nmathewson
Remove assert_all_pending_dns_resolves_ok().
f739aa7 
It hasn't been used since 2009.
@nmathewson
Make dns_cancel_pending_resolve() STATIC.
defd941 
It is not called by anything outside of the tests and dns.c.
@torproject-pusher torproject-pusher merged commit defd941 into torproject:master Feb 19, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment