Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract relay dns #1752

Merged
6 commits merged into from Feb 19, 2020
Merged

Extract relay dns #1752

6 commits merged into from Feb 19, 2020

Conversation

nmathewson
Copy link
Contributor

No description provided.

This is an automated commit, generated by this command:

./scripts/maint/rename_c_identifier.py \
        MIN_DNS_TTL_AT_EXIT MIN_DNS_TTL \
        MAX_DNS_TTL_AT_EXIT MAX_DNS_TTL \
        dns_clip_ttl clip_dns_ttl
This removes a dependency from the client code on feature/relay.
This saves about 1% for me on a binary compiled without relay mode.

Closes ticket 33366.
@coveralls
Copy link

coveralls commented Feb 18, 2020

Pull Request Test Coverage Report for Build 8165

  • 4 of 11 (36.36%) changed or added relevant lines in 3 files are covered.
  • 22 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.004%) to 63.412%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/or/connection_edge.c 4 5 80.0%
src/feature/client/addressmap.c 0 1 0.0%
src/feature/relay/dns.c 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
src/feature/hs/hs_common.c 1 84.27%
src/core/or/scheduler_kist.c 9 79.76%
src/core/or/scheduler.c 12 84.44%
Totals Coverage Status
Change from base Build 8142: 0.004%
Covered Lines: 50017
Relevant Lines: 78876

💛 - Coveralls

@ghost ghost merged commit defd941 into torproject:master Feb 19, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants