Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug32588 035 tests #1811

Open
wants to merge 6 commits into
base: maint-0.3.5
Choose a base branch
from
Open

Bug32588 035 tests #1811

wants to merge 6 commits into from

Conversation

nmathewson
Copy link
Contributor

No description provided.

teor2345 and others added 6 commits January 13, 2020 17:22
@teor2345
router: Stop advertising incorrect auto IPv6 ORPorts
43452b4 
When IPv6 ORPorts are set to "auto", tor relays and bridges would
advertise an incorrect port in their descriptor.

This may be a low-severity memory safety issue, because the published
port number may be derived from uninitialised or out-of-bounds memory
reads.

Fixes bug 32588; bugfix on 0.2.3.9-alpha.
@teor2345
router: Refactor IPv6 ORPort function logic
ab9078e 
Return early when there is no suitable IPv6 ORPort.
Show the address and port on error, using a convenience function.

Code simplification and refactoring.

Cleanup after 32588.
@nmathewson
Add tests for get_first_advertised_{addr,port}_by_type_af()
29af708
@nmathewson
Add a test for router_get_advertised_or_port_by_af().
704507f
@nmathewson
Extend test to handle router_get_advertised_ipv6_or_ap
189c7fa
@nmathewson
Add a test for the localhost case.
5607225
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8471

  • 15 of 18 (83.33%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 59.265%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/feature/relay/router.c 15 18 83.33%
Files with Coverage Reduction New Missed Lines %
src/feature/hs/hs_common.c 1 82.3%
Totals Coverage Status
Change from base Build 8452: 0.07%
Covered Lines: 43373
Relevant Lines: 73185
💛 - Coveralls

teor2345
teor2345 reviewed Mar 20, 2020
View reviewed changes
changes/bug32588
- Stop advertising incorrect IPv6 ORPorts in relay and bridge descriptors,
when the IPv6 port was configured as "auto". This may be a low-severity
memory safety issue, because the published port number may be derived
from uninitialised or out-of-bounds memory reads.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to change this changes file to remove "memory safety" before I merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nmathewson @coveralls @teor2345