Onionk protocommas2 #2039
Merged
Onionk protocommas2 #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
February 9, 2020 01:22
It was just a copypaste of the test above it. Fix on commit 15e59a1
commit 15e59a1 added a test for parsing an empty string twice.
Contrary to what 15e59a1 said, the C implementation has always accepted an empty string without complaint. Meanwhile the rust implementation has always given an error. Make the rust implementation match C. Also eliminate some more redundant tests. Fix on 0.3.3.1-alpha.
Contrary to its name, protover_contains_long_protocol_names() detects all parse errors, not just long names.
Consistently reject extra commas, instead of only rejecting leading commas. Fix on b2b2e1c. Fixes #27194; bugfix on 0.2.9.4-alpha.
Pull Request Test Coverage Report for Build 9745
💛 - Coveralls |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.