Warn the directory authority operator if their versions list is bogus #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents bug 26485; bugfix on 0.1.1.6-alpha.
Another way to try to prevent a recurrence of 26485.
tlyu
reviewed
Jul 17, 2018
src/or/dirserv.c
Outdated
| @@ -1042,6 +1041,37 @@ format_versions_list(config_line_t *ln) | |||
| smartlist_split_string(versions, ln->value, ",", | |||
| SPLIT_SKIP_SPACE|SPLIT_IGNORE_BLANK, 0); | |||
| } | |||
|
|
|||
| /* Handle the case where a dirauth operator has accidentally made some | |||
| * versions comma-separated instead of space-separated. */ | |||
There was a problem hiding this comment.
This comment seems backward. The code looks like it checks for and warns about spaces.
|
This was squashed and merged to 0.2.9 in a321d72. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents bug 26485; bugfix on 0.1.1.6-alpha.