#21900: Fallback to local DNS when no other nameservers are known #273
Conversation
nmathewson
requested changes
Oct 16, 2018
src/feature/relay/dns.c
Outdated
| return 0; | ||
| } | ||
|
|
||
| if (st.st_size == 0) |
If the stat() call failed above, then at this point, st.st_size will be uninitialized, and we're not allowed to look at it.
Checking if stat() succeeded in 770aee4.
src/feature/relay/dns.c
Outdated
| #endif /* defined(dns_option_hostsfile) && defined(use_libseccomp) */ | ||
|
|
||
| if (!missing_resolv_conf) { | ||
| log_info(LD_EXIT, "parsing resolver configuration in '%s'", conf_fname); |
It looks like this log message, and the messages after it, are still lower-cased in the latest version of the branch?
Reverted the last changes to lowercase in 917eeed.
src/feature/relay/dns.c
Outdated
| resolv_conf_fname = tor_strdup(conf_fname); | ||
| resolv_conf_mtime = st.st_mtime; | ||
| } else { | ||
| log_warn(LD_EXIT, "Could not read your resolv.conf - " |
This message should say what actual filename it tried to read.
Logging filename in a1656c9.
src/feature/relay/dns.c
Outdated
| } | ||
|
|
||
| tor_free(resolv_conf_fname); |
This tor_free() here will clear the value of rsolv_conf_fname that you set above...
Fixed - 4c1913a.
| log_warn(LD_EXIT, "unable to find any nameservers in '%s'.", | ||
| conf_fname); | ||
| } | ||
| resolv_conf_fname = tor_strdup(conf_fname); |
If resolv_conf_fname was already set, this will leak memory
…_addr() is not available
|
Closing in favor of PR 425 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
https://trac.torproject.org/projects/tor/ticket/21900
The text was updated successfully, but these errors were encountered: