Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket25573 034 #299

Closed

Conversation

mikeperry-tor
Copy link
Member

"Merge ready" 034 branch.

Mike Perry added 4 commits August 29, 2018 00:03
It does not modify the actual list.
We allow their CONNECTEDs, RESOLVEDs, ENDs, SENDMEs, and DATA cells to not
count as dropped until the windows are empty, or we get an END.

This commit does not change behavior. It only changes CIRC_BW event field
values.
Avoid data corrupton by avoiding mixing up old stream ids with new ones.

This commit changes client behavior.
TRUNCATED cells were ignored while in path bias. Now they are obeyed, and
cause us to tear down the circuit. The actual impact is minimal, since we
would just wait around for a probe that would never arrive before.

This commit changes client behavior.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 59.793% when pulling ce894e2 on mikeperry-tor:ticket25573-034 into 0ea622a on torproject:maint-0.3.4.

@nmathewson
Copy link
Contributor

This was merged in 035 and marked for possible backport.

@nmathewson nmathewson closed this Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants