Router split #372
Merged
Router split #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is also used by onion services, so it needs to go in another module.
This is preparation for having a routermode.h as well
Note that I haven't separated the headers yet (there's still an
(It turns out that some of the functions in router.h didn't even exist any more, so I just got to delete their declarations completely.)
Since this is completely core functionality, I'm putting it in core/mainloop, even though it depends on feature/hibernate. We'll have to sort that out in the future.
Make them only include the headers that they needed, and sort their headers while we're at it.
traumschule
reviewed
Sep 26, 2018
| #include "app/config/config.h" | ||
| #include "feature/hibernate/hibernate.h" | ||
|
|
||
| /** Return true iff our network is in some sense disabled or shutting down: |
There was a problem hiding this comment.
"iff" is intentional: It's an abbreviation for "if and only if". See https://en.wikipedia.org/wiki/If_and_only_if
traumschule
reviewed
Sep 26, 2018
| return get_options()->DisableNetwork || we_are_hibernating(); | ||
| } | ||
|
|
||
| /** Return true iff our network is in some sense "completely disabled" either |
dgoulet-tor
reviewed
Sep 26, 2018
| #include "core/or/or.h" | ||
| #include "core/mainloop/netstatus.h" | ||
| #include "app/config/config.h" | ||
| #include "feature/hibernate/hibernate.h" |
There was a problem hiding this comment.
I think we should either make a ticket or a big XXX: in the code at least so we kind of remember that relationship and that we should fix that.
Great part with a ticket, anyone could pick it up :D
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.